Skip to content

http: increase keepAliveTimeout default to 65 seconds#62782

Open
pimterry wants to merge 1 commit intonodejs:mainfrom
pimterry:keepalive-timeout-65s
Open

http: increase keepAliveTimeout default to 65 seconds#62782
pimterry wants to merge 1 commit intonodejs:mainfrom
pimterry:keepalive-timeout-65s

Conversation

@pimterry
Copy link
Copy Markdown
Member

This PR takes the code from #59203 (now stalled) and fixes it up to get the tests & linting passing so we can hopefully merge just in time for v26. Conclusion there I think it this is possibly semver-major, we're not 100% sure but better to release with a major bump initially at least.

See discussion there for context. I've kept @pras529 as a co-author on the commit.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Apr 16, 2026
Co-authored-by: Prashant Bansal <prashantbansal529@gmail.com>
Signed-off-by: Tim Perry <pimterry@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (2071c44) to head (a110f7e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62782      +/-   ##
==========================================
- Coverage   89.68%   89.68%   -0.01%     
==========================================
  Files         706      706              
  Lines      218143   218191      +48     
  Branches    41732    41741       +9     
==========================================
+ Hits       195650   195693      +43     
- Misses      14402    14423      +21     
+ Partials     8091     8075      -16     
Files with missing lines Coverage Δ
lib/_http_server.js 97.06% <100.00%> (-0.22%) ⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meixg meixg added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 17, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants