Skip to content

Reland AIX V8 fixes for clang#62894

Closed
richardlau wants to merge 2 commits intonodejs:mainfrom
richardlau:gnfix
Closed

Reland AIX V8 fixes for clang#62894
richardlau wants to merge 2 commits intonodejs:mainfrom
richardlau:gnfix

Conversation

@richardlau
Copy link
Copy Markdown
Member

@richardlau richardlau commented Apr 22, 2026

The V8 cherry-pick in #62656 contains a typo that is breaking our V8 CI (and instead of && in the conditional). Also the commit message title refers to the chromium-review reference and not the commit sha that the change landed as.

Revert the V8 cherry-pick from https://github.com/nodejs/node/pull/62656/commits and re-cherry-pick.

The correct change is already in #61898, so this is only necessary to fix V8 CI runs on current main and some open PRs that touch V8 (which is where I spotted the failures):

node/deps/v8/BUILD.gn

Line 1630 in d065ae8

if (current_os == "aix" && !is_clang) {

richardlau and others added 2 commits April 22, 2026 14:19
@richardlau
Revert "deps: V8: cherry-pick 7107287"
014c3bd 
This reverts commit 142b593.
@abmusse @richardlau
deps: V8: cherry-pick fcf8b990c73c
5d7272d 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
@richardlau richardlau added aix Issues and PRs related to the AIX platform. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 22, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2026
Renegade334
Renegade334 approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Renegade334 Renegade334 added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Fast-track has been requested by @Renegade334. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
abmusse
abmusse approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this up!

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72863/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7139/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7139/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7139/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72865/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72869/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72871/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72873/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 22, 2026

Landed in 9531947...acb1bd7

nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2026
@richardlau @nodejs-github-bot
Revert "deps: V8: cherry-pick 7107287"
c028766 
This reverts commit 142b593.

PR-URL: #62894
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2026
@abmusse @nodejs-github-bot
deps: V8: cherry-pick fcf8b990c73c
acb1bd7 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
PR-URL: #62894
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 23, 2026
@richardlau richardlau added dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@abmusse abmusse abmusse approved these changes

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau @nodejs-github-bot @panva @Renegade334 @abmusse