fs: fix glob early return skipping sibling entries#62901
Open
semimikoh wants to merge 1 commit intonodejs:mainfrom
Open
fs: fix glob early return skipping sibling entries#62901semimikoh wants to merge 1 commit intonodejs:mainfrom
semimikoh wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62901 +/- ##
==========================================
- Coverage 91.55% 89.63% -1.93%
==========================================
Files 355 706 +351
Lines 149381 219191 +69810
Branches 23364 41989 +18625
==========================================
+ Hits 136765 196463 +59698
- Misses 12354 14637 +2283
- Partials 262 8091 +7829
🚀 New features to boost your workflow:
|
ZYSzys
approved these changes
Apr 23, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache.seencheck from children iteration loop in#addSubpatterns(sync) and#iterateSubpatterns(async)returninside the loop exits the entire method, skipping all remaining siblingscache.addat the top of each method already prevents reprocessing and infinite recursionFixes: #62897
Test plan
test-fs-glob.mjsmultiple times to verify flakiness is resolved