crypto: deduplicate and canonicalize CryptoKey usages#62902
Open
panva wants to merge 3 commits intonodejs:mainfrom
Open
crypto: deduplicate and canonicalize CryptoKey usages#62902panva wants to merge 3 commits intonodejs:mainfrom
panva wants to merge 3 commits intonodejs:mainfrom
Conversation
Fixes: nodejs#62899 Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62902 +/- ##
==========================================
- Coverage 89.62% 89.61% -0.01%
==========================================
Files 706 706
Lines 219197 219224 +27
Branches 41995 42001 +6
==========================================
+ Hits 196459 196467 +8
- Misses 14640 14656 +16
- Partials 8098 8101 +3
🚀 New features to boost your workflow:
|
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was way more fun to track down than I expected.
The usage intersection operation requires the resulting
[[usages]]slot to contain "eachrecognized key usage valuethat appears in both a and b, in the order listed in thelist of recognized key usage values. This mandates both deduplication and a canonical ordering that is independent of the input order.list of recognized key usage valuesand hence the canonical order is in W3C Web Cryptography API Level 2And then further overloaded by Modern Algorithms in the Web Cryptography API to be
Fixes: #62899