util.inspect: fix numericSeparator for scientific notation numbers#62987
Open
AmSach wants to merge 1 commit intonodejs:mainfrom
Open
util.inspect: fix numericSeparator for scientific notation numbers#62987AmSach wants to merge 1 commit intonodejs:mainfrom
AmSach wants to merge 1 commit intonodejs:mainfrom
Conversation
When numericSeparator: true is set, util.inspect produces corrupted output like '1e-.1e-_7' for numbers in scientific notation (e.g. 1e-7). The fix adds an early return for scientific notation strings before the decimal-split + numeric separator logic runs. Fixes nodejs#62981
nodejs-github-bot
added
needs-ci
ljharb
requested changes
Apr 27, 2026
| return base; | ||
| return ctx.stylize(base, StringPrototypeToLowerCase(type)); | ||
| if (constructor !== null) { | ||
| const superName = ObjectGetPrototypeOf(value).name; |
Member
There was a problem hiding this comment.
why would a [[Prototype]] object necessarily have a .name? and why would a class-related change belong in a PR fixing number display?
Comment on lines
-2417
to
+2431
| ctx.indentationLvl += 2; | ||
| let i = 0; | ||
| ctx.indentationLvl += 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62981
When numericSeparator: true is set, util.inspect produces corrupted output like '1e-.1e-_7' for numbers in scientific notation (e.g. 1e-7).
The fix adds an early return for scientific notation strings before the decimal-split + numeric separator logic runs.