http2: expose writable stream state on compat response#63003
Open
cookesan wants to merge 1 commit intonodejs:mainfrom
Open
http2: expose writable stream state on compat response#63003cookesan wants to merge 1 commit intonodejs:mainfrom
cookesan wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63003 +/- ##
==========================================
- Coverage 91.47% 89.67% -1.81%
==========================================
Files 357 707 +350
Lines 150883 219517 +68634
Branches 23778 42089 +18311
==========================================
+ Hits 138026 196842 +58816
- Misses 12582 14579 +1997
- Partials 275 8096 +7821
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63000
This adds the missing writableObjectMode and writableNeedDrain getters to Http2ServerResponse in the HTTP/2 compatibility layer. The getters mirror the underlying stream, matching the existing writable state properties.
The writable-properties test now covers both properties.
Tests: