Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/internal/http2/compat.js
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,14 @@ class Http2ServerResponse extends Stream {
return this[kStream].writableFinished;
}

get writableObjectMode() {
return this[kStream].writableObjectMode;
}

get writableNeedDrain() {
return this[kStream].writableNeedDrain;
}

get writableLength() {
return this[kStream].writableLength;
}
Expand Down
31 changes: 31 additions & 0 deletions test/fixtures/http2/test-writable-props.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict';

const { createServer } = require('http2');
const { mustCall } = require('../common');

const server = createServer();
server.on('stream', (stream) => {
// writableObjectMode and writableNeedDrain should be defined (boolean)
console.log('writableObjectMode:', stream.writableObjectMode);
console.log('writableNeedDrain:', stream.writableNeedDrain);
if (typeof stream.writableObjectMode !== 'boolean') {
throw new Error(`writableObjectMode should be boolean, got ${stream.writableObjectMode}`);
}
if (typeof stream.writableNeedDrain !== 'boolean') {
throw new Error(`writableNeedDrain should be boolean, got ${stream.writableNeedDrain}`);
}
stream.respond();
stream.end('ok');
});
server.listen(0, mustCall(() => {
const client = require('http2').connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.on('response', () => {
req.on('data', () => {});
req.on('end', () => {
client.close();
server.close();
console.log('PASS: writableObjectMode and writableNeedDrain are booleans');
});
});
}));
2 changes: 2 additions & 0 deletions test/parallel/test-http2-res-writable-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const server = http2.createServer(common.mustCall((req, res) => {
const hwm = req.socket.writableHighWaterMark;
assert.strictEqual(res.writableHighWaterMark, hwm);
assert.strictEqual(res.writableLength, 0);
assert.strictEqual(typeof res.writableObjectMode, 'boolean');
assert.strictEqual(typeof res.writableNeedDrain, 'boolean');
res.write('');
const len = res.writableLength;
res.write('asd');
Expand Down