src: swap dotenv and config file parsing order#63035
Open
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Open
src: swap dotenv and config file parsing order#63035marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63035 +/- ##
==========================================
- Coverage 91.49% 89.63% -1.86%
==========================================
Files 358 708 +350
Lines 151574 220375 +68801
Branches 23921 42270 +18349
==========================================
+ Hits 138679 197539 +58860
- Misses 12619 14713 +2094
- Partials 276 8123 +7847
🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Apr 29, 2026
marco-ippolito
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes more sense that env variable override config file and not the opposite