Skip to content

doc: replace Visual Studio 2022 Evergreen version reference with 17.14#63211

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MikeMcC399:typo-visual-studio-2022-evergreen-version
May 14, 2026
Merged

doc: replace Visual Studio 2022 Evergreen version reference with 17.14#63211
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MikeMcC399:typo-visual-studio-2022-evergreen-version

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

BUILDING > Windows Prerequisites > Manual Install
is corrected to refer to Visual Studio 2022 Current channel Version 17.14, instead of 17.4.

This was a typo from PR #61655

Visual Studio 2022 Current channel according to Evergreen bootstrappers is 17.14.

Backporting

Currently, branches v24.x, v25.x & v26.x contain the incorrect version reference "17.4" in BUILDING.md

Does not apply to v22.x.

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 9, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 9, 2026 13:45
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

This is a correction to my own mistake, so from my point of view it's author ready PRs that have at least one approval, no pending requests for changes, and a CI started. . I can't add the label myself though, as I'm not a Collaborator in this repo.

@lpinca lpinca added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2026
@nodejs-github-bot nodejs-github-bot merged commit 843dc5f into nodejs:main May 14, 2026
45 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 843dc5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants