test: fix compiler warnings in test_node_crypto.cc#63341
Open
mpatankar6 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63341 +/- ##
==========================================
- Coverage 90.05% 90.05% -0.01%
==========================================
Files 714 714
Lines 225490 225490
Branches 42633 42635 +2
==========================================
- Hits 203072 203069 -3
Misses 14193 14193
- Partials 8225 8228 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: fix compiler warnings in test_node_crypto.cc
Fixes the warnings by using the correct literal type. Also removed some
assertions which were just identity tests for constexprs. The bounds
checks are sufficient to verify the constants are nonzero and reasonable,
and will survive OpenSSL changes without needing to be updated.
Fixes: #63325
Signed-off-by: Mihir Patankar mpatankar06@gmail.com