Skip to content

test_runner: Better visibility when using --test-rerun#63429

Closed
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:better-rerun-visibility
Closed

test_runner: Better visibility when using --test-rerun#63429
MoLow wants to merge 2 commits into
nodejs:mainfrom
MoLow:better-rerun-visibility

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented May 19, 2026

No description provided.

MoLow added 2 commits May 19, 2026 14:08
@MoLow
test_runner: preserve run duration when using test-rerun
6397b6a 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@MoLow
test_runner: show replayed-from-attempt hint in spec reporter
fe1b923 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 19, 2026

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 19, 2026
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (4ee7567) to head (fe1b923).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/test.js 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #63429   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         714      714           
  Lines      225876   225893   +17     
  Branches    42737    42732    -5     
=======================================
+ Hits       203408   203436   +28     
+ Misses      14244    14243    -1     
+ Partials     8224     8214   -10
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/rerun.js 92.30% <100.00%> (+0.09%) ⬆️
lib/internal/test_runner/reporter/utils.js 95.28% <100.00%> (+0.13%) ⬆️
lib/internal/test_runner/test.js 96.94% <85.71%> (-0.09%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 19, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73550/

@MoLow MoLow changed the title test_runner: Better visibility when using -test-rerun test_runner: Better visibility when using --test-rerun May 19, 2026
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 21, 2026

Landed in a29a118...5c87012

nodejs-github-bot pushed a commit that referenced this pull request May 21, 2026
@MoLow @nodejs-github-bot
test_runner: preserve run duration when using test-rerun
1455277 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit that referenced this pull request May 21, 2026
@MoLow @nodejs-github-bot
test_runner: show replayed-from-attempt hint in spec reporter
5c87012 
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #63429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@avivkeller avivkeller avivkeller approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow @nodejs-github-bot @benjamingr @avivkeller @atlowChemi