Skip to content

stream: settle pending broadcast reads on return#63603

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-pending-next-hang-2
Open

stream: settle pending broadcast reads on return#63603
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-pending-next-hang-2

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 28, 2026

This updates broadcast async iterator cleanup so a pending
next() settles when the consumer is returned.

When a broadcast consumer has an outstanding next() and
return() is called before data arrives, the pending read is now
resolved with { done: true, value: undefined } during detach.

Fixes: #63519


Assisted-by: openai:gpt-5.5

Resolve pending next() calls when broadcast consumers are returned,
so the promise does not remain pending after iterator cleanup.

Fixes: nodejs#63519

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 28, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (4639dcb) to head (273ae63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63603      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.02%     
==========================================
  Files         730      730              
  Lines      234695   234696       +1     
  Branches    43956    43954       -2     
==========================================
+ Hits       211927   211976      +49     
+ Misses      14494    14431      -63     
- Partials     8274     8289      +15     
Files with missing lines Coverage Δ
lib/internal/streams/iter/broadcast.js 85.25% <100.00%> (+0.01%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream/iter: pending next() hangs after iterator return()

2 participants