This repository was archived by the owner on Apr 26, 2024. It is now read-only.
feat(learn): use displayTitle and minor redirect fixes#2783
Merged
ovflowd merged 9 commits intonodejs:mainfrom Sep 21, 2022
Merged
feat(learn): use displayTitle and minor redirect fixes#2783ovflowd merged 9 commits intonodejs:mainfrom
displayTitle and minor redirect fixes#2783ovflowd merged 9 commits intonodejs:mainfrom
Conversation
ovflowd
added
bug
Codecov ReportBase: 66.02% // Head: 62.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 66.02% 62.52% -3.50%
==========================================
Files 118 124 +6
Lines 1351 1457 +106
Branches 342 361 +19
==========================================
+ Hits 892 911 +19
- Misses 422 505 +83
- Partials 37 41 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions
bot
removed
the
create-preview
|
Please find a preview at: https://staging.nodejs.dev/2783/ |
AugustinMauroy
approved these changes
Sep 21, 2022
Member
Author
|
Merging so that I'd unblock @AugustinMauroy translation changes :) @AugustinMauroy you know the drill, just rebase your PRs and update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
displayTitleforlearnpages and moves the pages to "category folders" so that files are better organised.This PR also does a minor fix by always enabling
redirectInBrowserwhich fixes the redirect issues on the GitHub Pages.Related Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.