Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix: add missing main landmarks (a11y)#2811

Merged
nschonni merged 3 commits intonodejs:mainfrom
EmmaDawsonDev:fix/missing-landmarks-a11y
Oct 1, 2022
Merged

Fix: add missing main landmarks (a11y)#2811
nschonni merged 3 commits intonodejs:mainfrom
EmmaDawsonDev:fix/missing-landmarks-a11y

Conversation

@EmmaDawsonDev
Copy link
Copy Markdown
Contributor

Description

The download page was missing a main tag so I changed the wrapping div tag to a main tag to be semantically correct and work better for users of assistive tech.

Related Issues

No related issue

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little addition! Thank you!

@nschonni nschonni merged commit 185cb09 into nodejs:main Oct 1, 2022
@nschonni nschonni added the hacktoberfest-accepted Used to label PR's label Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted Used to label PR's

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants