Add eslint plugin yml to enable correct YAML parsing#2868
Add eslint plugin yml to enable correct YAML parsing#2868nschonni merged 13 commits intonodejs:mainfrom lyqht:feature/lint-yml
Conversation
Codecov ReportBase: 66.02% // Head: 63.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
- Coverage 66.02% 63.82% -2.21%
==========================================
Files 118 124 +6
Lines 1351 1465 +114
Branches 342 367 +25
==========================================
+ Hits 892 935 +43
- Misses 422 490 +68
- Partials 37 40 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ovflowd
left a comment
There was a problem hiding this comment.
The plugin and changes make sense to me.
Plug-ins have been cleaned out. Only a minor suggestion remains
Co-authored-by: Nick Schonning <nschonni@gmail.com> Signed-off-by: Estee Tey Siew Wen <estee.tsw@gmail.com>
Signed-off-by: Nick Schonning <nschonni@gmail.com>
Signed-off-by: Nick Schonning <nschonni@gmail.com>
Signed-off-by: Nick Schonning <nschonni@gmail.com>
Signed-off-by: Nick Schonning <nschonni@gmail.com>
|
@lyqht I pushed a few commits to tie the check back to the CI. It's flagging one file if you want to run the format again locally to address the last file |
|
@nschonni haha i hope that's the 1 file you're talking about 😆 |
|
@nschonni don't forget please to add the |
|
You don't actually need the label if the repo has the tag and the PR is merged https://hacktoberfest.com/participation/#pr-mr-details. The label doesn't hurt though, and I have slapped it on a few, since it might speed up the PRs being counted as accepted. Otherwise, merged PRs get counted after 7 days |
|
Oooh, that I didn’t know 👀 thanks for explaining! |
|
The tag is also helpful if you want it to count, but might not be able to land it before the event ends |
|
Thank you, Nick! That’s very informative 🙏 |
Description
While working on #2854, I realized that linting & formatting is not applied to the
.ymlfiles. Hence this PR adds them.Example of invalid YAML file giving 1 error
Notes
There are a few available yml configurations as per the plugin, but I applied the
yml:baseconfiguration for now as currently there are a few files that would fail the recommended/standard configuration (the 70+ errors above). It's up to the maintainers if they prefer those instead.P.S. I didn't create an issue, but I hope this get a
hacktoberfest-acceptedlabel 😆Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.