-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(api): add link to json docs #2911
Conversation
cb2a525 to
a733ef7
Compare
a733ef7 to
d3fb740
Compare
|
Please find a preview at: https://staging.nodejs.dev/2911/ |
|
@ovflowd let me know if there's anything to address here! Also if you don't mind throwing the |
Codecov ReportBase: 66.02% // Head: 67.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 66.02% 67.05% +1.03%
==========================================
Files 118 137 +19
Lines 1351 1536 +185
Branches 342 359 +17
==========================================
+ Hits 892 1030 +138
- Misses 422 464 +42
- Partials 37 42 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hey @sethetter I haven't had time to review this PR yet and to check the preview. Will do asap 🙃 |
benhalverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Just need to resolve the conflict. Thanks for working on this issue 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase 😅 (Probably needs to be added to src/components/ApiComponents/Components
And do the changes I mentioned before 🙏
|
@ovflowd @benhalverson alright I think everything is addressed and ready to merge! Thanks everyone for the feedback and review :) |
|
@sethetter I believe you still forgot to move the component to the |
|
Please find a preview at: https://staging.nodejs.dev/2911/ |
|
@ovflowd alright, feedback addressed! |
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few things to be done 😅
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you so much for this contribution! Everything looks great ;D

Description
This PR adds links to the JSON version of API doc pages by mirroring the
EditLinkcomponent visually and using thetitleandversionto build a link to the JSON docs hosted on nodejs.org.Related Issues
#2894
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.