-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Closed
Labels
website redesignIssue/PR part of the Node.js Website RedesignIssue/PR part of the Node.js Website Redesign
Description
⚠️ MAKE SURE TO DELETE THE CORRECT FILES HERE. SOME ARE OUT OF SCOPE
The Banner component is being ported to the new website design. But we will remove it for now so as to not complicate our styles.
Remove all references to it within the current codebase. This includes:
- all files within components/Common/Banner
- if this is the last work within a higher directory, delete that too
- perform a global search for the component. If found elsewhere, remove its usage
- all references to the component within internationalization files.
- look for
components.common.banner.*keys withini18n/locales/{locale}.jsonfiles - ensure these files remain valid JSON by being mindful of commas when deleting lines
- look for
DO NOT DELETE
components/Home/Banner.tsx
As with all contributions, run local commands to ensure the deletion was cleanly executed:
-
npx turbo lint -
npx turbo format -
npx turbo test -
npx turbo build -
npx turbo serve
Metadata
Metadata
Assignees
Labels
website redesignIssue/PR part of the Node.js Website RedesignIssue/PR part of the Node.js Website Redesign