Lighthouse report sometimes failing in CI

[mikeesto]

How to reproduce the issue:

See, for example: https://github.com/nodejs/nodejs.org/actions/runs/6684891162/job/18162610188?pr=6067

 /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/fix-broken-link-to-page*:refs/remotes/origin/fix-broken-link-to-page* +refs/tags/fix-broken-link-to-page*:refs/tags/fix-broken-link-to-page*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 16 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/fix-broken-link-to-page*:refs/remotes/origin/fix-broken-link-to-page* +refs/tags/fix-broken-link-to-page*:refs/tags/fix-broken-link-to-page*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 13 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/fix-broken-link-to-page*:refs/remotes/origin/fix-broken-link-to-page* +refs/tags/fix-broken-link-to-page*:refs/tags/fix-broken-link-to-page*
  Error: The process '/usr/bin/git' failed with exit code 1

[bmuenzenmeyer]

testing a theory to make this more stable - but i'll admit i dont exactly know what causes it to fail yet

[mikeesto]

This is another very recent example of it failing: https://github.com/nodejs/nodejs.org/actions/runs/6713687116/job/18245658050?pr=6072

It seems to only happen when a PR is from a fork which makes me think that something is amiss here:

nodejs.org/.github/workflows/lighthouse.yml

Lines 40 to 50 in ed0ddfa

	with:
	# Since we checkout the HEAD of the current Branch, if the Pull Request comes from a Fork
	# we want to clone the fork's repository instead of the base repository
	# this allows us to have the correct history tree of the perspective of the Pull Request's branch
	# If the Workflow is running on `merge_group` or `push` events it fallsback to the base repository
	repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
	# We checkout the branch itself instead of a specific SHA (Commit) as we want to ensure that this Workflow
	# is always running with the latest `ref` (changes) of the Pull Request's branch
	# If the Workflow is running on `merge_group` or `push` events it fallsback to `github.ref` which will often be `main`
	# or the merge_group `ref`
	ref: ${{ github.event.pull_request.head.ref || github.ref }}

Perhaps we could add some debugging temporarily to work out what's going on. The error message that we currently get is not helpful. Something like this:

- name: Print Repository and Ref Details
  run: |
    echo "Repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}"
    echo "Ref: ${{ github.event.pull_request.head.ref || github.ref }}"

[bmuenzenmeyer]

the thing i want to test is whether the second checkout is even necessary. i suspect it was copy-pasta from a source

[ovflowd]

the thing i want to test is whether the second checkout is even necessary. i suspect it was copy-pasta from a source

Right the repository field is actually exactly what allows us to checkout their fork, if this was an issue, I don't see how the other CI checks that use the same command would be failing...

[ovflowd]

It looks like it's setting the wrong repository.