Skip to content

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Aug 5, 2019

Spaces inside code span elements

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's best to omit blog/release/* from the linting. The text being changed here is directly from the commit log. Even if there are typographical errors in the commit log, I think it's best that the text match.

(Alternatively, maybe we can add an HTML comment that instructs the linter to skip this line? No idea if the tool we're using permits that but remark-lint does, so maybe this one does too?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be ignored from the command line glob, but that would still show up in IDEs. A disable command could be added to the files/template to disable it in the files by adding <!-- markdownlint-disable--> or for specific rules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to get this PR landed, can you add a comment to disable it for these lines in the changelog rather than altering the lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess a different approach might be needed for #2360

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've disabled it at the file level

@nschonni nschonni closed this Aug 5, 2019
@nschonni nschonni force-pushed the fix--MD038/no-space-in-code branch from aef2768 to 332f84d Compare August 5, 2019 18:32
@nschonni
Copy link
Member Author

nschonni commented Aug 5, 2019

Arg, GitHub decided to close the PR on a force push. Looks like a new service glitch/bug, so I'll need to resubmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants