Skip to content

Conversation

@JulioGsn
Copy link
Contributor

Description

The URL for the "Overview of Blocking vs Non-Blocking" in about page of this current docs was not working.

Validation

I fixed the link in the file "/pages/en/about/index.md" that was directing to "en/learn/overview-of-blocking-vs-non-blocking" (which was not being found). Now it is directing to "en/docs/guides/blocking-vs-non-blocking"

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@JulioGsn JulioGsn requested a review from a team as a code owner October 29, 2023 16:41
@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 4:42pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Running Lighthouse audit...

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.41% (333/349) 77.21% (61/79) 93.05% (67/72)

Unit Test Report

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 6.849s ⏱️

@ovflowd ovflowd merged commit ea22870 into nodejs:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants