Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Dec 7, 2024

Description

Adopting the workflow from nodejs/node - https://github.com/rtCamp/action-slack-notify - which will be useful as we add more users with write access to the repo as part of CODEOWNERS work, AND it introduces accountability for existing users.

Should anyone be able to force push at all? I think the answer remains yes, but I want more visibility to it.

Validation

Post-merge, force pushes will send a Slack message to #nodejs-website

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings December 7, 2024 21:47
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner December 7, 2024 21:47
@vercel
Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 7, 2024 9:47pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@AugustinMauroy
Copy link
Member

Should anyone be able to force push at all?

IMO, no, we have a wait-before-merge policy. In my opinion, merge force push should only be used when it's absolutely necessary to restore/fix something.

@AugustinMauroy
Copy link
Member

Also in the rest markdown documents there is no specific mention of #nodejs-website maybe we should do so.

@bmuenzenmeyer
Copy link
Contributor Author

IMO, no, we have a wait-before-merge policy. In my opinion, merge force push should only be used when it's absolutely necessary to restore/fix something.

Correct - sorry if my language was not clear. I agree there are circumstances that make it necessary / expedient / useful to have force push.

@bmuenzenmeyer
Copy link
Contributor Author

Also in the rest markdown documents there is no specific mention of #nodejs-website maybe we should do so.

If I am understanding your concern, the webhook secret has the channel baked in to it, that's why you don't see it on the action config at all.

@bmuenzenmeyer bmuenzenmeyer marked this pull request as draft December 8, 2024 14:42
@bmuenzenmeyer
Copy link
Contributor Author

switching this to DRAFT to make it clear the webhook secret is NOT yet in place

@AugustinMauroy
Copy link
Member

If I am understanding your concern, the webhook secret has the channel baked in to it, that's why you don't see it on the action config at all.

Oops, I didn't make myself clear, I was talking about adding a reference to the slack channel in the documentation to explain that part of the discussion takes place there. For example on the readme or contributing.md

@bmuenzenmeyer
Copy link
Contributor Author

SLACK_WEBHOOK created by openjs admins, I've added it as a repo secret

@bmuenzenmeyer bmuenzenmeyer marked this pull request as ready for review January 24, 2025 21:23
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Jan 24, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.422s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort here, @bmuenzenmeyer <3

@ovflowd ovflowd added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit 8c3512f Jan 26, 2025
16 checks passed
@ovflowd ovflowd deleted the notify-on-force-push branch January 26, 2025 16:15
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jan 27, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants