-
-
Couldn't load subscription status.
- Fork 6.4k
Introduce notify-on-force-push workflow #7322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
IMO, no, we have a wait-before-merge policy. In my opinion, merge force push should only be used when it's absolutely necessary to restore/fix something. |
|
Also in the rest markdown documents there is no specific mention of |
Correct - sorry if my language was not clear. I agree there are circumstances that make it necessary / expedient / useful to have force push. |
If I am understanding your concern, the webhook secret has the channel baked in to it, that's why you don't see it on the action config at all. |
|
switching this to DRAFT to make it clear the webhook secret is NOT yet in place |
Oops, I didn't make myself clear, I was talking about adding a reference to the slack channel in the documentation to explain that part of the discussion takes place there. For example on the readme or contributing.md |
|
SLACK_WEBHOOK created by openjs admins, I've added it as a repo secret |
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort here, @bmuenzenmeyer <3
Description
Adopting the workflow from nodejs/node - https://github.com/rtCamp/action-slack-notify - which will be useful as we add more users with
writeaccess to the repo as part of CODEOWNERS work, AND it introduces accountability for existing users.Should anyone be able to force push at all? I think the answer remains yes, but I want more visibility to it.
Validation
Post-merge, force pushes will send a Slack message to #nodejs-website
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.