Skip to content

chore: Minor changes on download page #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 6 commits into from
Dec 28, 2024
Merged

chore: Minor changes on download page #7367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a562a5
chore: mobile layout and skeleton sizes
canerakdas Dec 28, 2024
a03a288
chore: layout on not-found page
canerakdas Dec 28, 2024
a65e280
chore: resolve conflict
canerakdas Dec 28, 2024
980cacc
chore: mobile skeleton size
canerakdas Dec 28, 2024
6394613
chore: review updates
canerakdas Dec 28, 2024
87068fc
chore: error page layout
canerakdas Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/app/[locale]/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const ErrorPage: FC<{ error: Error }> = () => {
const t = useTranslations();

return (
<GlowingBackdropLayout>
<GlowingBackdropLayout kind="default">
500
<h1 className="special -mt-4 text-center">
{t('layouts.error.internalServerError.title')}
Expand Down
2 changes: 1 addition & 1 deletion apps/site/app/[locale]/not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const NotFoundPage: FC = () => {
const t = useTranslations();

return (
<GlowingBackdropLayout>
<GlowingBackdropLayout kind="default">
404
<h1 className="special -mt-4 text-center">
{t('layouts.error.notFound.title')}
Expand Down
6 changes: 2 additions & 4 deletions apps/site/components/Downloads/Release/BlogPostLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
import type { FC, PropsWithChildren } from 'react';
import { useContext } from 'react';

import LinkWithArrow from '@/components/Downloads/Release/LinkWithArrow';
import Link from '@/components/Link';
import { ReleaseContext } from '@/providers/releaseProvider';

const BlogPostLink: FC<PropsWithChildren> = ({ children }) => {
const { release } = useContext(ReleaseContext);
const version = release.versionWithPrefix;

return (
<LinkWithArrow href={`/blog/release/${version}`}>{children}</LinkWithArrow>
);
return <Link href={`/blog/release/${version}`}>{children}</Link>;
};

export default BlogPostLink;
2 changes: 1 addition & 1 deletion apps/site/components/Downloads/Release/PlatformDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const PlatformDropdown: FC = () => {
placeholder={t('layouts.download.dropdown.unknown')}
ariaLabel={t('layouts.download.dropdown.installMethod')}
onChange={platform => platform && release.setPlatform(platform)}
className="min-w-20"
className="min-w-28"
inline={true}
/>
);
Expand Down
14 changes: 11 additions & 3 deletions apps/site/components/Downloads/Release/PrebuiltDownloadButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ const PrebuiltDownloadButtons: FC = () => {
: '';

return (
<div className="my-4 flex flex-wrap gap-2">
<div className="my-4 flex flex-col gap-2 sm:flex-row">
<Skeleton
loading={os === 'LOADING' || platform === ''}
hide={OS_NOT_SUPPORTING_INSTALLERS.includes(os)}
>
<Button href={installerUrl} size="small" className="min-w-56">
<Button
href={installerUrl}
size="small"
className="w-full min-w-56 sm:w-auto"
>
<CloudArrowDownIcon />

{t('layouts.download.buttons.installer', {
Expand All @@ -46,7 +50,11 @@ const PrebuiltDownloadButtons: FC = () => {
</Skeleton>

<Skeleton loading={os === 'LOADING' || platform === ''}>
<Button href={binaryUrl} size="small" className="min-w-56">
<Button
href={binaryUrl}
size="small"
className="w-full min-w-56 sm:w-auto"
>
<CloudArrowDownIcon />

{t('layouts.download.buttons.binary', {
Expand Down
2 changes: 1 addition & 1 deletion apps/site/components/Downloads/Release/ReleaseCodeBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const ReleaseCodeBox: FC = () => {
)}

<Skeleton loading={renderSkeleton}>
<CodeBox language={displayName} className="min-h-[16rem]">
<CodeBox language={displayName} className="min-h-[16.5rem]">
<code dangerouslySetInnerHTML={{ __html: parsedSnippets }} />
</CodeBox>
</Skeleton>
Expand Down
9 changes: 4 additions & 5 deletions apps/site/layouts/GlowingBackdrop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ import WithNavBar from '@/components/withNavBar';
import styles from './layouts.module.css';

type GlowingBackdropLayoutProps = PropsWithChildren<{
kind?: 'home';
kind?: 'home' | 'default';
}>;

const GlowingBackdropLayout: FC<GlowingBackdropLayoutProps> = ({
kind = 'home',
children,
}) => (
const GlowingBackdropLayout: FC<
PropsWithChildren<GlowingBackdropLayoutProps>
> = ({ kind = 'home', children }) => (
<>
<WithNavBar />
<div className={styles.centeredLayout}>
Expand Down
Loading