Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 28, 2024

This PR removes unused navigation.json entries, language localization entries, fixes an edge scenario for Operating System entries, fixes AlertBox content organization and adds a noscript for the Downloads page.

@ovflowd ovflowd requested a review from a team as a code owner December 28, 2024 21:10
@vercel
Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 28, 2024 9:30pm

@ovflowd ovflowd requested a review from canerakdas December 28, 2024 21:10
@github-actions
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

Requesting fast-track, cc @nodejs/nodejs-website as this fixes some bugs

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
83.85% (587/700) 64.74% (180/278) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
123 0 💤 0 ❌ 0 🔥 4.916s ⏱️

@ovflowd ovflowd enabled auto-merge December 28, 2024 21:35
@ovflowd ovflowd added this pull request to the merge queue Dec 28, 2024
Merged via the queue into main with commit c9b01b5 Dec 28, 2024
17 checks passed
@ovflowd ovflowd deleted the chore/minor-download-fixes branch December 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants