Skip to content

Conversation

@araujogui
Copy link
Member

Description

Fix SVG props casings

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings June 27, 2025 18:33
@araujogui araujogui requested a review from a team as a code owner June 27, 2025 18:33
@vercel
Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 27, 2025 6:34pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the casing of SVG properties in the Nodejs logo component to align with React's camelCase conventions.

  • Corrected the clip-path attribute to clipPath for the SVG group element in the pride variant.
  • Updated feFlood attributes from flood-opacity to floodOpacity in two locations.
Comments suppressed due to low confidence (3)

packages/ui-components/Icons/Logos/Nodejs.tsx:75

  • The update to 'clipPath' is appropriate for React's camelCase convention. Please verify that any other SVG attributes follow the same pattern.
          <g clipPath="url(#clip0_1_1661)">

packages/ui-components/Icons/Logos/Nodejs.tsx:186

  • Converting 'flood-opacity' to 'floodOpacity' adheres to React's attribute naming. Ensure consistency for similar SVG attributes.
            <feFlood floodOpacity="0" result="BackgroundImageFix" />

packages/ui-components/Icons/Logos/Nodejs.tsx:221

  • The adjustment to 'floodOpacity' is correct. Double-check any other occurrences of SVG attributes to maintain consistency.
            <feFlood floodOpacity="0" result="BackgroundImageFix" />

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (3615c30) to head (562e0df).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7902      +/-   ##
==========================================
+ Coverage   75.47%   75.49%   +0.01%     
==========================================
  Files         101      101              
  Lines        8311     8311              
  Branches      218      218              
==========================================
+ Hits         6273     6274       +1     
+ Misses       2036     2035       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd
Copy link
Member

ovflowd commented Jun 27, 2025

Let's fast-track this lil fella <3

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jun 27, 2025
@ovflowd ovflowd enabled auto-merge June 27, 2025 20:14
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd added this pull request to the merge queue Jun 27, 2025
Merged via the queue into nodejs:main with commit 7d8b9c5 Jun 27, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants