-
-
Couldn't load subscription status.
- Fork 6.4k
fix: svg props casing #7902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: svg props casing #7902
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes the casing of SVG properties in the Nodejs logo component to align with React's camelCase conventions.
- Corrected the clip-path attribute to clipPath for the SVG group element in the pride variant.
- Updated feFlood attributes from flood-opacity to floodOpacity in two locations.
Comments suppressed due to low confidence (3)
packages/ui-components/Icons/Logos/Nodejs.tsx:75
- The update to 'clipPath' is appropriate for React's camelCase convention. Please verify that any other SVG attributes follow the same pattern.
<g clipPath="url(#clip0_1_1661)">
packages/ui-components/Icons/Logos/Nodejs.tsx:186
- Converting 'flood-opacity' to 'floodOpacity' adheres to React's attribute naming. Ensure consistency for similar SVG attributes.
<feFlood floodOpacity="0" result="BackgroundImageFix" />
packages/ui-components/Icons/Logos/Nodejs.tsx:221
- The adjustment to 'floodOpacity' is correct. Double-check any other occurrences of SVG attributes to maintain consistency.
<feFlood floodOpacity="0" result="BackgroundImageFix" />
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7902 +/- ##
==========================================
+ Coverage 75.47% 75.49% +0.01%
==========================================
Files 101 101
Lines 8311 8311
Branches 218 218
==========================================
+ Hits 6273 6274 +1
+ Misses 2036 2035 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Let's fast-track this lil fella <3 |
|
Lighthouse Results
|
Description
Fix SVG props casings
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.