-
-
Couldn't load subscription status.
- Fork 6.4k
feat(supporters): sort supporters and add link to profile #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
about to board a plane, knocked this out quick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sorts supporters by donation amount and adds profile links to supporter avatars by utilizing the OpenCollective API response data.
- Adds sorting functionality to order supporters by total donation amount
- Adds profile field to supporter data structure and components
- Updates Avatar component to include clickable profile links
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/site/types/partners.ts | Adds profile field to Supporters type definition |
| apps/site/next-data/generators/supportersData.mjs | Implements sorting by donation amount and extracts profile data |
| apps/site/components/Common/Supporters/index.tsx | Updates component to pass profile URL to Avatar component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8221 +/- ##
==========================================
- Coverage 76.60% 76.44% -0.16%
==========================================
Files 115 115
Lines 9623 9643 +20
Branches 323 316 -7
==========================================
Hits 7372 7372
- Misses 2250 2270 +20
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Description
Closes #8198
Used the response mentioned in the issue - https://opencollective.com/nodejs/members/all.json
Validation
From a quick glance, the order is the same as the current display.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.