-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(server): more server components #8239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts several React components from client-side to server-side components by removing 'use client' directives and refactoring interactive elements to support server-side rendering.
- Removed
'use client'directives from NavBar, Separator, Supporters, and LinkTabs components - Replaced interactive Select component with StatelessSelect to eliminate client-side state management
- Simplified LinkTabs implementation by removing router navigation logic
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/Containers/NavBar/index.tsx | Removed 'use client' directive to enable server-side rendering |
| packages/ui-components/src/Common/Separator/index.tsx | Removed 'use client' directive to enable server-side rendering |
| packages/ui-components/src/Common/Select/index.module.css | Added z-index styling to dropdown element |
| packages/ui-components/src/Common/BaseLinkTabs/index.tsx | Replaced Select with StatelessSelect and removed onSelect prop |
| packages/ui-components/src/Common/BaseLinkTabs/index.module.css | Simplified styling by removing nested selector rules |
| apps/site/components/Common/Supporters/index.tsx | Removed 'use client' directive to enable server-side rendering |
| apps/site/components/Common/LinkTabs.tsx | Removed 'use client' directive and router navigation logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8239 +/- ##
=======================================
Coverage 76.44% 76.44%
=======================================
Files 115 115
Lines 9643 9643
Branches 317 317
=======================================
Hits 7372 7372
Misses 2270 2270
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Latest Build on this branchLatest build on
|
Can we have a CI step that comments the build size differences between runs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I like the commit name "MOAR SERVER" |
|
I'm fast-tracking this :) |
This PR moves a few components from
'use client'to RSC.