-
-
Couldn't load subscription status.
- Fork 6.4k
Fix link to Node.js Website Team in CONTRIBUTING.md #8244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated link to Node.js Website Team members list. Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes an outdated link in CONTRIBUTING.md to point contributors to the correct Node.js Website Team reference.
- Update team reference link from nodejs/nodejs.org to the web-team repository’s MEMBERS.md section
- Keep contributor guidance text unchanged
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8244 +/- ##
==========================================
- Coverage 76.43% 76.39% -0.05%
==========================================
Files 115 115
Lines 9643 9643
Branches 317 318 +1
==========================================
- Hits 7371 7367 -4
- Misses 2271 2275 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Fast tracking |
|
as a reminder: fast tracks should get a 👍 from someone other than the person requesting |
|
|
I checked the text As written, you are right. I haven't been operating that way for years now. Comparing to node core - they handle this ambiguity by always requiring two approvals (even if the fast tracker counts as one). Unsure if it matters, just pointing out. |
Noticed this when preparing nodejs/web-team#55