Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

Noticed this when preparing nodejs/web-team#55

Updated link to Node.js Website Team members list.

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer marked this pull request as ready for review October 19, 2025 19:53
@bmuenzenmeyer bmuenzenmeyer requested review from a team as code owners October 19, 2025 19:53
Copilot AI review requested due to automatic review settings October 19, 2025 19:53
@vercel
Copy link

vercel bot commented Oct 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 19, 2025 7:54pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes an outdated link in CONTRIBUTING.md to point contributors to the correct Node.js Website Team reference.

  • Update team reference link from nodejs/nodejs.org to the web-team repository’s MEMBERS.md section
  • Keep contributor guidance text unchanged

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.39%. Comparing base (44ad1e2) to head (16f363b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8244      +/-   ##
==========================================
- Coverage   76.43%   76.39%   -0.05%     
==========================================
  Files         115      115              
  Lines        9643     9643              
  Branches      317      318       +1     
==========================================
- Hits         7371     7367       -4     
- Misses       2271     2275       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Oct 19, 2025
@avivkeller avivkeller added this pull request to the merge queue Oct 19, 2025
@avivkeller
Copy link
Member

Fast tracking

Merged via the queue into main with commit 02bf873 Oct 19, 2025
16 checks passed
@avivkeller avivkeller deleted the bmuenzenmeyer-patch-1 branch October 19, 2025 21:55
@bmuenzenmeyer
Copy link
Contributor Author

as a reminder: fast tracks should get a 👍 from someone other than the person requesting

@avivkeller
Copy link
Member

Approval Needed: Must have at least one 👍 reaction if the fast-tracker is the PR author

@bmuenzenmeyer
Copy link
Contributor Author

I checked the text
https://github.com/nodejs/nodejs.org/blob/main/docs/collaborator-guide.md#fast-tracking-process

As written, you are right. I haven't been operating that way for years now.

Comparing to node core - they handle this ambiguity by always requiring two approvals (even if the fast tracker counts as one).

Unsure if it matters, just pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants