Skip to content

Conversation

avivkeller
Copy link
Member

Fixes nodejs/web-team#9.

An alternative to this approach is a governance file that contains the link within it, rather than removing it entirely.

@avivkeller avivkeller requested a review from a team as a code owner October 22, 2025 21:59
@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 21:59
@avivkeller avivkeller requested review from a team as code owners October 22, 2025 21:59
@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 22, 2025 10:00pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the local GOVERNANCE.md file from the repository and instead points users to the centralized governance document maintained by the web-team. This change consolidates governance documentation in a single location to avoid duplication and maintenance overhead.

Key changes:

  • Adds a reference link to the web-team's governance document in the README
  • Removes the local GOVERNANCE.md file entirely
  • Updates CODEOWNERS to remove the governance file entry

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
README.md Adds link to centralized governance document in web-team repository
GOVERNANCE.md Removes entire local governance document (90 lines deleted)
.github/CODEOWNERS Removes GOVERNANCE.md ownership entry as file no longer exists

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.56%. Comparing base (ad86795) to head (213aa86).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8261      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.02%     
==========================================
  Files         117      117              
  Lines        9733     9733              
  Branches      329      329              
==========================================
- Hits         7453     7452       -1     
- Misses       2278     2279       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmuenzenmeyer
Copy link
Collaborator

i felt like you already did this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Governance: Sync up and GHA

5 participants