Skip to content

Conversation

@avivkeller
Copy link
Member

Copilot AI review requested due to automatic review settings October 27, 2025 21:26
@avivkeller avivkeller requested review from a team as code owners October 27, 2025 21:26
@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 27, 2025 9:27pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom type mappings in the invalid-type-reference linting rule by introducing a typeMap option. This allows users to define custom type references that should be considered valid.

  • Added typeMap parameter to the invalid-type-reference rule
  • Updated the testRule utility to accept rule options
  • Added test coverage for custom type references

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/remark-lint/src/rules/invalid-type-reference.mjs Added typeMap parameter to rule function and passed it to transformTypeToReferenceLink
packages/remark-lint/src/rules/tests/utils.mjs Added ruleOptions parameter to testRule utility function
packages/remark-lint/src/rules/tests/invalid-type-reference.test.mjs Added test case for custom type references using the new options parameter
packages/remark-lint/src/api.mjs Added typeMap property to Options typedef
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.57%. Comparing base (e14424a) to head (f133ace).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8275      +/-   ##
==========================================
+ Coverage   76.56%   76.57%   +0.01%     
==========================================
  Files         117      117              
  Lines        9733     9751      +18     
  Branches      329      330       +1     
==========================================
+ Hits         7452     7467      +15     
- Misses       2279     2282       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmuenzenmeyer
Copy link
Contributor

would it be worth pinning to a specific version here? this is like saying latest

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 6433784 Oct 29, 2025
12 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the bump-doc-kit branch October 29, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants