Skip to content

Conversation

@avivkeller
Copy link
Member

Fixes #8281
cc @richardlau

While the actions logs don't show it, the actual error that occured here was that the workflow did not correctly pass v24.11.0 as an argument.

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller requested a review from a team as a code owner October 28, 2025 17:38
Copilot AI review requested due to automatic review settings October 28, 2025 17:38
@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 28, 2025 5:39pm

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.57%. Comparing base (aba34ea) to head (781ad38).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8282      +/-   ##
==========================================
+ Coverage   76.55%   76.57%   +0.02%     
==========================================
  Files         117      117              
  Lines        9733     9733              
  Branches      329      328       -1     
==========================================
+ Hits         7451     7453       +2     
+ Misses       2280     2278       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the GitHub Actions workflow for creating release posts by adding the -- separator between the script name and its arguments when using node --run.

  • Adds -- before "$VERSION" in the workflow command to properly pass arguments to the npm script
  • Ensures the version argument is correctly forwarded to the release-post script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller
Copy link
Member Author

I'm merging this without a "formal" fast-track approval as a hotfix

@richardlau
Copy link
Member

ah right, I ran the script directly with node and not via the script in package.json which is why I didn't get the error locally.

Merged via the queue into main with commit 53a5031 Oct 28, 2025
23 checks passed
@avivkeller avivkeller deleted the fix-release-post branch October 28, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Release Blog Post workflow failed for v24.11.0

4 participants