-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: require admin approval for .github
#8363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the @nodejs/web-admins team as a required reviewer for changes to the .github directory, ensuring that administrative approval is obtained for GitHub configuration changes alongside the existing @nodejs/web-infra team review.
- Adds
@nodejs/web-adminsteam as an additional code owner for the.githubdirectory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8363 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 118 118
Lines 9903 9903
Branches 336 336
=======================================
Hits 7555 7555
Misses 2346 2346
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Is this needed still, I thought the SHA pins were removed from the repo allow-list, so web-infra can merge bumps? Admins would only be needed for net-new actions now? |
I was just wondering this - I think this covers the new action case |
|
Yeh, if this is just for new actions now I think I'd probably prefer to allow web-infra to merge without admin approval. This ask originally came out of us merging Dependabot updates and breaking CI, but I think there's a lot less risk if it's just new actions that'll break without admin involvement. |
Fixes #7986