Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

Description

Removed the image altogether.

  • The source file is 1.3 MB, which is a lot to add to the repo. Smaller when converted by Next.js, but still causes CLS on load.
  • No other learn content has a top-level image like that, so it's an outlier
  • As placed, it takes precedent over the heading, which is odd too.
  • I think it is nice to have on the userland repo content or README, but not on the site.

With resolution:

image

Without at all

image

Validation

Related Issues

resolves #8333

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings November 24, 2025 15:57
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner November 24, 2025 15:57
@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 24, 2025 3:57pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a large image from the userland migrations documentation page to improve performance and maintain consistency with other learn content. The image was causing Cumulative Layout Shift (CLS) issues and was an outlier as no other learn documentation includes top-level images.

Key Changes

  • Removed the external image reference that was placed above the main heading in the userland migrations documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.23%. Comparing base (8504a85) to head (45304ce).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8364      +/-   ##
==========================================
- Coverage   76.29%   76.23%   -0.06%     
==========================================
  Files         118      118              
  Lines        9903     9903              
  Branches      336      337       +1     
==========================================
- Hits         7555     7550       -5     
- Misses       2346     2351       +5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/0adaba579573515a.js 204.32 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/75799b324d0f7d78.js 204.32 KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken image in "Userland Migrations"

6 participants