Skip to content

Conversation

@avivkeller
Copy link
Member

I assume this'll fix #8370

Updated code block formatting for clarity.

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings November 24, 2025 21:49
@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 24, 2025 9:50pm

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/diagnostics

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the formatting of a code block in the flame graphs documentation by removing incorrect indentation and adding proper syntax highlighting. The indented code block was likely causing rendering issues in the documentation.

  • Removed 3-space indentation from the perf record code block
  • Added bash language specifier for syntax highlighting
  • Made formatting consistent with other code blocks in the same document

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.23%. Comparing base (f9b57d7) to head (8f8736b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8371   +/-   ##
=======================================
  Coverage   76.23%   76.23%           
=======================================
  Files         118      118           
  Lines        9903     9903           
  Branches      337      337           
=======================================
  Hits         7550     7550           
  Misses       2351     2351           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/053217c192132099.js 204.32 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/7bc5bfbae1ad7c75.js 204.32 KB

@efekrskl
Copy link
Contributor

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird layout issue in Learn page

6 participants