-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(formatting): don't indent code block #8371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated code block formatting for clarity. Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/diagnostics Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the formatting of a code block in the flame graphs documentation by removing incorrect indentation and adding proper syntax highlighting. The indented code block was likely causing rendering issues in the documentation.
- Removed 3-space indentation from the
perf recordcode block - Added
bashlanguage specifier for syntax highlighting - Made formatting consistent with other code blocks in the same document
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8371 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 118 118
Lines 9903 9903
Branches 337 337
=======================================
Hits 7550 7550
Misses 2351 2351
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
Indeed seems to be the fix: https://nodejs-org-git-fix-8370-openjs.vercel.app/en/learn/diagnostics/flame-graphs Thanks! |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks resolved over at https://nodejs-org-git-fix-8370-openjs.vercel.app/en/learn/diagnostics/flame-graphs
I assume this'll fix #8370