This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: fixing stateless reset (again)#332
Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
Member
Author
|
PR to fix upstream: ngtcp2/ngtcp2#214 |
36 tasks
The update to ngtcp2-25 appears to have broken the association of the initial stateless reset token and the server's initial CID. See: ngtcp2/ngtcp2#213 This is a work in progress until that is fixed
2ebacbf to
f867947
Compare
Member
Author
|
Upstream fix landed, PR rebased and ready to go! |
addaleax
approved these changes
Feb 10, 2020
jasnell
added a commit
that referenced
this pull request
Feb 10, 2020
The update to ngtcp2-25 appears to have broken the association of the initial stateless reset token and the server's initial CID. See: ngtcp2/ngtcp2#213 This is a work in progress until that is fixed PR-URL: #332 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Feb 10, 2020
PR-URL: #332 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Feb 10, 2020
PR-URL: #332 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
Author
|
Landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update to ngtcp2-25 appears to have broken the association of the
initial stateless reset token and the server's initial CID.
See: ngtcp2/ngtcp2#213
We can see the failure in the debug output:
The line
QuicSession Client (zzz, 15) Updating connection ID dc90c8b81dce2649a79ef3a8909b7a9eb9bf6c8f (has reset token? No)reports that there is no stateless reset token associated with the initial CID but the server provided transport params does include the reset token (Stateless Reset Token: 2f39a010f89d95a95f35a9d00c39d862)This is a work in progress until that is fixed