Skip to content

Removed process-nexttick-args as it's not used anymore#354

Merged
mcollina merged 2 commits into
masterfrom
remove-deps
Aug 13, 2018
Merged

Removed process-nexttick-args as it's not used anymore#354
mcollina merged 2 commits into
masterfrom
remove-deps

Conversation

@mcollina
Copy link
Copy Markdown
Member

It's not used in lib/, just to check if tests pass everywhere.

@vweevers
Copy link
Copy Markdown
Contributor

A search shows it's still used?

@mcollina
Copy link
Copy Markdown
Member Author

@vweevers thanks for checking. I've removed it everywhere, let's see what CI says.

@mcollina
Copy link
Copy Markdown
Member Author

CI seems happy. @vweevers can you please check?

Copy link
Copy Markdown
Contributor

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 23c4ff0 into master Aug 13, 2018
@mcollina mcollina deleted the remove-deps branch August 13, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants