Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 30, 2025

My use case for this is that in nixpkgs, at any point in time we already have a verified hash for previous Node.js release, we only need to verify hash of "new" releases, so ideally it should fail if a new release is signed with a key listed as no longer active.

@aduh95 aduh95 force-pushed the only-active-keys branch from 65500d4 to 3ead0a2 Compare June 30, 2025 18:46
@aduh95 aduh95 requested a review from a team June 30, 2025 18:47
@richardlau
Copy link
Member

I'm +1 to the idea -- it's not clear to me how we're going to be managing this key ring -- it looks like the cli.sh changes would add keys to both keyrings (which probably makes sense), but then how are we excluding keys (the non-active ones) from the the new keyring?

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 30, 2025

I'm +1 to the idea -- it's not clear to me how we're going to be managing this key ring -- it looks like the cli.sh changes would add keys to both keyrings (which probably makes sense), but then how are we excluding keys (the non-active ones) from the the new keyring?

In #36, I'm adding:

  • a workflow that would tell us when the keyring is not longer in sync with nodejs/node README.
  • a script to regenerate both keyrings.

So when a key gets retired, we'd get a hint from CI to update the keyring, which we can either gpg --delete, or we can reganerate the keyring altogether.

@aduh95 aduh95 merged commit 220b69f into main Jul 2, 2025
@aduh95 aduh95 deleted the only-active-keys branch July 2, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants