refactor(npm-db): update references field to be an array#316
Merged
Conversation
vdeturckheim
approved these changes
Jun 19, 2018
dgonzalez
approved these changes
Jun 19, 2018
pxlpnk
force-pushed
the
fix/npm-db-references
branch
from
ac9ea83 to
20fbd73
Compare
Member
Author
|
Rebased and migrated the files |
pxlpnk
force-pushed
the
fix/npm-db-references
branch
from
20fbd73 to
43e58f3
Compare
8 tasks
lirantal
approved these changes
Jun 24, 2018
vdeturckheim
approved these changes
Jun 25, 2018
Member
|
I'll merge this tomorrow if no opposition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR comes with a (
tools/migrations/transform_references.js) script that changes the existing database.You can check out the branch and run:
node tools/migrations/transform_references.js). Then runnpm testafterwards to check the migration.The migrated files where not yet checked in to keep the PR less noisy. I will supply those changes as soon as the proposed changes are approved. The PR will be failing until those changes are applied.
This is the second PR to get #200 moving forward.