feat: add factory option to BalancedPool#1237
Merged
ronag merged 3 commits intonodejs:mainfrom Feb 20, 2022
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 93.85% 94.03% +0.18%
==========================================
Files 43 43
Lines 4052 4057 +5
==========================================
+ Hits 3803 3815 +12
+ Misses 249 242 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nipeshkc7
force-pushed
the
add-factory-balanced-pool
branch
from
ec67852 to
24945d7
Compare
ronag
reviewed
Feb 16, 2022
Member
ronag
left a comment
ronag
left a comment
There was a problem hiding this comment.
Can you add a test for the factory actually being used?
Contributor
Author
Sure can do that. |
Member
|
Could you add the option to our docs? I'm ok with the behavior - I assume the factory can override any of the agent options. |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* feat: add factory option to BalancedPool * add tests for balanced-pool with factory option * update docs for balanced-pool with factory option
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* feat: add factory option to BalancedPool * add tests for balanced-pool with factory option * update docs for balanced-pool with factory option
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* feat: add factory option to BalancedPool * add tests for balanced-pool with factory option * update docs for balanced-pool with factory option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1220