Skip to content

fix: RequestInit doesn't allow explicit undefined#1242

Merged
ronag merged 1 commit intonodejs:mainfrom
chlonel:request-init-treatment-of-undefined
Feb 19, 2022
Merged

fix: RequestInit doesn't allow explicit undefined#1242
ronag merged 1 commit intonodejs:mainfrom
chlonel:request-init-treatment-of-undefined

Conversation

@chlonel
Copy link
Copy Markdown
Contributor

@chlonel chlonel commented Feb 19, 2022

Fixes: #1225

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #1242 (14f0bc5) into main (b081930) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   93.87%   94.05%   +0.17%     
==========================================
  Files          43       43              
  Lines        4052     4052              
==========================================
+ Hits         3804     3811       +7     
+ Misses        248      241       -7     
Impacted Files Coverage Δ
lib/fetch/request.js 85.47% <100.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b081930...14f0bc5. Read the comment docs.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit df3f54c into nodejs:main Feb 19, 2022
Comment thread lib/fetch/request.js
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch options do not allow explicit undefined

5 participants