Allow string[] as Record value on HeadersInit#1244
Merged
ronag merged 3 commits intonodejs:mainfrom Feb 28, 2022
dgadelha:fix/fetch-headers-type
Merged
Allow string[] as Record value on HeadersInit#1244ronag merged 3 commits intonodejs:mainfrom dgadelha:fix/fetch-headers-type
ronag merged 3 commits intonodejs:mainfrom
dgadelha:fix/fetch-headers-type
Conversation
ronag
approved these changes
Feb 21, 2022
targos
reviewed
Feb 21, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 43 43
Lines 4071 4071
=======================================
Hits 3830 3830
Misses 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ethan-Arrowood
requested changes
Feb 21, 2022
Collaborator
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
Type change is fine but the test should exist somewhere else I think
Ethan-Arrowood
approved these changes
Feb 21, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Mar 1, 2022
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a TypeScript-only change, undici already handles Records with string[] values: https://runkit.com/embed/972d5c6lsor2
A test was created to ensure this feature works properly