fix: remove hash from intercept dispatch key#1273
Merged
ronag merged 1 commit intonodejs:mainfrom Mar 11, 2022
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
=======================================
Coverage 94.10% 94.11%
=======================================
Files 44 44
Lines 4090 4093 +3
=======================================
+ Hits 3849 3852 +3
Misses 241 241 ☔ View full report in Codecov by Sentry. |
ronag
approved these changes
Mar 11, 2022
jennyEckstein
left a comment
jennyEckstein
left a comment
There was a problem hiding this comment.
I tested the changes on my side, everything works as expected. Thank you @galvez
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1245
As per RFC 3986, clients are not supposed to send URI fragments to servers when they retrieve a document.