Skip to content

build: fix lint errors and introduce CI check#1277

Merged
mcollina merged 5 commits intonodejs:mainfrom
JustinBeckwith:linty
Mar 14, 2022
Merged

build: fix lint errors and introduce CI check#1277
mcollina merged 5 commits intonodejs:mainfrom
JustinBeckwith:linty

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Mar 14, 2022

While working on a different task, I tried running npm run lint:fix in hopes of making sure my PR was clean and tidy. It generated ... a lot of unrelated changes. This PR does a few things:

  • Runs npm run lint:fix to capture low hanging fruit
  • Manually fixes issues standard couldn't automatically fix
  • Introduces a new CI check to ensure the linter passes

Happy to discuss any changes!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 14, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (5a0bf7e) to head (e6c090c).
⚠️ Report is 2096 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
- Coverage   94.11%   94.11%   -0.01%     
==========================================
  Files          44       44              
  Lines        4097     4096       -1     
==========================================
- Hits         3856     3855       -1     
  Misses        241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JustinBeckwith
Copy link
Copy Markdown
Contributor Author

I'm at a bit of a loss .... npm run lint passes locally with the latest LTS release, but seems to be not passing in CI!? I'll keep poking, but wondering if others have any ideas.

@KhafraDev
Copy link
Copy Markdown
Member

KhafraDev commented Mar 14, 2022

sameOrigin is a utility method exported in lib/fetch/util.js; error wasn't caught before because the previous condition isn't possible. It definitely isn't a global 😄.

edit: fixed in 09f00fb?

@JustinBeckwith
Copy link
Copy Markdown
Contributor Author

yuuuuuup, that was it :) I was thinking "surely this isn't just broken" :)

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2d7059b into nodejs:main Mar 14, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants