tests: fix CI failure#1286
Merged
ronag merged 1 commit intonodejs:mainfrom Mar 17, 2022
KhafraDev:fix-ci-failure
Merged
Conversation
Member
Author
|
CI failure from the benchmarks now 😒 |
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1221
Detailing the issue: #1221 (comment)
tl;dr delaying the abort made the test flaky
One thing to note: the node-fetch tests here are outdated as of node-fetch/node-fetch@015798e but they use ESM and rely heavily on internal methods that would require a lot of work to port over. I also don't know if any other tests are flaky, so the node-fetch suite might still cause issues.