Skip to content

chore: fix duplicated error import in test/agent.js#1288

Merged
mcollina merged 1 commit intonodejs:mainfrom
is2ei:refactor-agetn-test
Mar 17, 2022
Merged

chore: fix duplicated error import in test/agent.js#1288
mcollina merged 1 commit intonodejs:mainfrom
is2ei:refactor-agetn-test

Conversation

@is2ei
Copy link
Copy Markdown
Contributor

@is2ei is2ei commented Mar 17, 2022

This PR refactors test/agent.js.

  • It imports ../ and ../index but those are the same.
  • It uses InvalidArgumentError and errors.InvalidArgumentError but those are the same.

@is2ei is2ei force-pushed the refactor-agetn-test branch from 21052c4 to f4c12ed Compare March 17, 2022 13:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.14%. Comparing base (d7eac3e) to head (f4c12ed).
⚠️ Report is 2093 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.02%     
==========================================
  Files          44       44              
  Lines        4098     4098              
==========================================
+ Hits         3857     3858       +1     
+ Misses        241      240       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f1739cf into nodejs:main Mar 17, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants