feat: implement (basic) webidl & headers comments#1495
Merged
mcollina merged 4 commits intonodejs:mainfrom Jun 18, 2022
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 49 50 +1
Lines 4293 4335 +42
=======================================
+ Hits 4069 4109 +40
- Misses 224 226 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ronag
approved these changes
Jun 15, 2022
mcollina
requested changes
Jun 15, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
Could you add some tests for the new code?
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
mcollina
requested changes
Jun 15, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
Could you add some tests for the new code?
Member
Author
|
added tests all new stuff should be tested with existing tests already (everything passed other than Symbol tests which shouldn't have worked), just added some tests for invalid/valid characters. |
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #933
WebIdl is pretty cool and it's used rather heavily in the fetch spec. Implementing a subset of it (that we need) will make everything much easier once it's finished. I can explain how it'll help if you want, just don't want to write out an essay if you don't care lol
I only did the
Headersclass as a PoC and in the process discovered a load of bugs and decided just to add the spec comments since I was already adding a ton to it and fixing stuff anyways 😄.p.s.: it's very clear that
HeadersListwas not supposed to be Map-like structure, as each key can be duplicated and the actual appending doesn't occur until you use.get(...). Not a big deal, just something I noticed when working on it.