test: fix flaky http2-dispatcher test #4633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed flaky
Dispatcher#Connecttest intest/http2-dispatcher.jsthat was intermittently failing withERR_HTTP2_STREAM_ERRORand timing out.Problem
The test was using
response.body.pipe(stream)without proper error handling. When HTTP/2 streams encountered errors (likeNGHTTP2_INTERNAL_ERROR), they became uncaught exceptions, causing random test failures and timeouts.Solution
.pipe()withpipeline()for proper error handlingTest Plan
🤖 Generated with Claude Code