Skip to content

fix fetch stripping trailing ? from url#4837

Merged
mcollina merged 1 commit intonodejs:mainfrom
KhafraDev:fetch-strip-question
Feb 23, 2026
Merged

fix fetch stripping trailing ? from url#4837
mcollina merged 1 commit intonodejs:mainfrom
KhafraDev:fetch-strip-question

Conversation

@KhafraDev
Copy link
Member

fixes #4836

claude wrote the tests, I wrote the fix

@KhafraDev
Copy link
Member Author

a ✅ in the ci without rerunning any jobs? it's a miracle

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 088f72c into nodejs:main Feb 23, 2026
37 checks passed
@mcollina
Copy link
Member

a ✅ in the ci without rerunning any jobs? it's a miracle

I've been relentlessy chasing this for months ;).

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.14%. Comparing base (1867fb7) to head (1b823ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4837      +/-   ##
==========================================
- Coverage   93.19%   93.14%   -0.06%     
==========================================
  Files         109      109              
  Lines       34228    34228              
==========================================
- Hits        31900    31882      -18     
- Misses       2328     2346      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KhafraDev KhafraDev deleted the fetch-strip-question branch February 23, 2026 18:49
@github-actions github-actions bot mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch strips trailing question mark from the URL, doesn't match browser behaviour

3 participants