fix(handler): preserve latin1 header encoding in WrapHandler#4859
Merged
mcollina merged 1 commit intonodejs:mainfrom Mar 4, 2026
Merged
fix(handler): preserve latin1 header encoding in WrapHandler#4859mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
metcoder95
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4859 +/- ##
=======================================
Coverage 93.13% 93.14%
=======================================
Files 109 109
Lines 34243 34249 +6
=======================================
+ Hits 31893 31902 +9
+ Misses 2350 2347 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
WrapHandlerheader/trailer conversion to preserve latin1/isomorphic byte semantics when bridging new handler API -> old handler API.Today
WrapHandlerusesBuffer.from(value)(utf-8 default), which can corrupt non-ASCII header bytes when the old API later reads as latin1.What changed
onRequestUpgradeonResponseStartonResponseEndtest/issue-3934.js:WrapHandler preserves latin1 header bytesValidation
node --test test/issue-3934.jsnpm run lintFixes #4797.