Skip to content

docs(dispatcher): use RFC 2606 domains in interceptor examples#4873

Merged
mcollina merged 1 commit intonodejs:mainfrom
nthbotast:docs/4866-rfc2606-dispatcher-examples
Mar 8, 2026
Merged

docs(dispatcher): use RFC 2606 domains in interceptor examples#4873
mcollina merged 1 commit intonodejs:mainfrom
nthbotast:docs/4866-rfc2606-dispatcher-examples

Conversation

@nthbotast
Copy link
Contributor

@nthbotast nthbotast commented Mar 8, 2026

What

  • replace http://example.com with http://service.example in Dispatcher interceptor examples
  • keep sample semantics unchanged while using RFC 2606-reserved domains

Why

Issue #4866 asks to avoid non-RFC2606 examples in docs/tests. This updates the Dispatcher docs section to use a reserved .example domain.

Validation

  • git diff --check

Partially addresses #4866.

Signed-off-by: Nathanael BOT <nathanaelbot@minidenathanael.home>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (fb05ad6) to head (7932f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4873   +/-   ##
=======================================
  Coverage   93.02%   93.03%           
=======================================
  Files         112      112           
  Lines       35176    35176           
=======================================
+ Hits        32723    32726    +3     
+ Misses       2453     2450    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2e76bec into nodejs:main Mar 8, 2026
36 of 37 checks passed
@github-actions github-actions bot mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants