fix(test): client wasm compatible with clang 22#4909
Merged
metcoder95 merged 2 commits intonodejs:mainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4909 +/- ##
=======================================
Coverage ? 92.90%
=======================================
Files ? 112
Lines ? 35638
Branches ? 0
=======================================
Hits ? 33108
Misses ? 2530
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gurgunday
approved these changes
Mar 20, 2026
Member
|
Cc @metcoder95 |
metcoder95
approved these changes
Mar 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4668
Rationale
The test used a strict
deepStrictEqualon the full exports list, which fails when clang >= 22 exports__stack_pointeras a global symbol.This will make the test also more "future-proof" in case of future export additions.
Changes
Changed the assertion to check that each required export is present, without failing on unexpected compiler-internal symbols.